Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

rework outputmgrapplyortest() #287

Merged
merged 2 commits into from
Aug 13, 2022
Merged

rework outputmgrapplyortest() #287

merged 2 commits into from
Aug 13, 2022

Conversation

sevz17
Copy link
Collaborator

@sevz17 sevz17 commented Aug 11, 2022

first disable requested monitors, then enable and/or change mode, x and y, etc.
This is mostly what sway does

first disable requested monitors, then enable and/or change mode, x and y, etc.
This is mostly what sway does
@sevz17
Copy link
Collaborator Author

sevz17 commented Aug 11, 2022

With this I am able to change to a a non-custom mode, if I try to change to a custom mode dwl segfaults in wlr_output_commit()

@sevz17
Copy link
Collaborator Author

sevz17 commented Aug 11, 2022

With this I am able to change to a a non-custom mode, if I try to change to a custom mode dwl segfaults in wlr_output_commit()

seems like https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3641 could fix the segfault setting a custom mode.

@dimkr
Copy link
Contributor

dimkr commented Aug 12, 2022

This is mostly what sway does

How about integrating https://github.com/djpohly/dwl/compare/main...dimkr:dwl:fallback.patch?

@sevz17
Copy link
Collaborator Author

sevz17 commented Aug 13, 2022

This is mostly what sway does

How about integrating https://github.com/djpohly/dwl/compare/main...dimkr:dwl:fallback.patch?

I see the use case, however I don't think it should be on the mainline, but I am not strongly opposed to merging it.

Please open a pr, let @djpohly decide if we merge it.

@sevz17 sevz17 merged commit 48396a1 into djpohly:main Aug 13, 2022
@sevz17 sevz17 deleted the wlr-randr branch August 13, 2022 04:21
@sevz17 sevz17 mentioned this pull request Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting mode via wlr-randr causes screen artifact
2 participants