Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

initialize xkb_rules.options to a null pointer #247

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

Humm42
Copy link
Contributor

@Humm42 Humm42 commented Jun 2, 2022

Initializing it to an empty string had broken configuring xkbcommon
through the environment (XKB_DEFAULT_OPTIONS).

Fixes: ae31391 ("initialize rules and xkb_rules")

Initializing it to an empty string had broken configuring xkbcommon
through the environment (XKB_DEFAULT_OPTIONS).

Fixes: ae31391 ("initialize rules and xkb_rules")
@sevz17
Copy link
Collaborator

sevz17 commented Jun 5, 2022

Maybe it's worth initialize all xbk_rules with a NULL pointer, doesn't it?

@djpohly
Copy link
Owner

djpohly commented Jun 5, 2022

It was initialized to a NULL pointer before. Any fields not specified in an initializer (when an initializer is given) are by C standard initialized to the zero value of their type. (-pedantic might be overly so...)

@sevz17
Copy link
Collaborator

sevz17 commented Jun 5, 2022

Well, with #245 there are no default flags, and we can leave rules and xkb_rules empty

@Humm42
Copy link
Contributor Author

Humm42 commented Jun 6, 2022 via email

@sevz17 sevz17 merged commit 3a77f02 into djpohly:main Jun 14, 2022
@sevz17
Copy link
Collaborator

sevz17 commented Jun 14, 2022

Thanks!

gwnichol added a commit to gwnichol/dwl that referenced this pull request Jun 15, 2022
@sevz17 sevz17 mentioned this pull request Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants