Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

Handle 'wlr_seat_get_keyboard' possibly returning null. #230

Merged
merged 1 commit into from
May 9, 2022

Conversation

BenJarg
Copy link
Contributor

@BenJarg BenJarg commented May 2, 2022

I've gotten segfaults with certain uses of wtype because of dwl not checking if wlr_seat_get_keyboard returns NULL (looks like others also had this issue, see #124 ). This solution handles this case the same way sway handles this.

@BenJarg BenJarg force-pushed the null-wlr_seat_get_keyboard branch from fcdf92e to addca92 Compare May 9, 2022 11:59
@BenJarg BenJarg force-pushed the null-wlr_seat_get_keyboard branch from addca92 to e0d310f Compare May 9, 2022 12:00
@sevz17
Copy link
Collaborator

sevz17 commented May 9, 2022

Does this close #124?

@BenJarg
Copy link
Contributor Author

BenJarg commented May 9, 2022

Yes, I believe it does.

@sevz17 sevz17 linked an issue May 9, 2022 that may be closed by this pull request
@sevz17 sevz17 merged commit 07d56c6 into djpohly:main May 9, 2022
@sevz17
Copy link
Collaborator

sevz17 commented May 9, 2022

Thanks!

@BenJarg BenJarg deleted the null-wlr_seat_get_keyboard branch May 9, 2022 20:38
@sevz17 sevz17 mentioned this pull request Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash when using wtype not in a text input field
2 participants