Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

Add configuration options for touchpads #229

Merged
merged 1 commit into from
May 22, 2022
Merged

Add configuration options for touchpads #229

merged 1 commit into from
May 22, 2022

Conversation

BenJarg
Copy link
Contributor

@BenJarg BenJarg commented Apr 26, 2022

This may make more sense as a patch, but seems like a somewhat basic configuration option for touchpads (and has been asked for in #141).

@sevz17
Copy link
Collaborator

sevz17 commented May 13, 2022

It may worth adding more options, like changing the default accel speed, and also the default accel profile

@pm4rcin
Copy link

pm4rcin commented May 17, 2022

@sevz17 check my comment here and the one above. Because someone has to make decision how we should handle the configuration.

@sevz17
Copy link
Collaborator

sevz17 commented May 17, 2022

It will definitely be by config.h

@pm4rcin pm4rcin mentioned this pull request May 18, 2022
@BenJarg BenJarg changed the title Add configuration for disable while typing for touchpads Add configuration options for touchpads May 18, 2022
@BenJarg
Copy link
Contributor Author

BenJarg commented May 18, 2022

So now this configures disable while typing, the accel speed, and accel profile. Is there anything else reasonable that should be on this list?

@pm4rcin
Copy link

pm4rcin commented May 18, 2022

Here's all the available options. @sevz17 do we want every option from there?

@BenJarg
Copy link
Contributor Author

BenJarg commented May 18, 2022

Thanks, perhaps left handed mode and middle button emulation should also be added. I suppose we should decide what exactly to include though, and whether or not we want everything available.

@sevz17 sevz17 linked an issue May 18, 2022 that may be closed by this pull request
@sevz17
Copy link
Collaborator

sevz17 commented May 18, 2022

I think these options should be configured, does anyone want to add or remove some of these?

@pm4rcin
Copy link

pm4rcin commented May 19, 2022

Basically we will have all the options for Touchpad so I think it's good. I think we should provide comments for every option so people don't have to look for docs etc.

@BenJarg
Copy link
Contributor Author

BenJarg commented May 22, 2022

Ok, I've added everything on that list (except dwtp), and comments with values for the options of things that you would need to look up. I didn't add dwtp because it looks like it won't be available until libinput 1.21, and the latest release is 1.20, so as far as I can tell it's a future setting (someone correct me if I misunderstood the docs).

@sevz17
Copy link
Collaborator

sevz17 commented May 22, 2022

Other thing, at least for me it's more understandable place the variables below the comment about it.

@sevz17
Copy link
Collaborator

sevz17 commented May 22, 2022

Perhaps the if statement for tap_to_click should be replaced with a similar line if LIBINPUT_CONFIG_TAP_ENABLED is always going to be 1?

Yes, do it.
Also, the comment at the end of the function should be replaced.

@sevz17 sevz17 merged commit ecbc2c6 into djpohly:main May 22, 2022
@sevz17
Copy link
Collaborator

sevz17 commented May 22, 2022

Thanks!

@BenJarg BenJarg deleted the dwt branch May 22, 2022 22:34
@sevz17 sevz17 mentioned this pull request Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Touchpad Support
3 participants