Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatter): reverted chained function formatting #721

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

christopherpickering
Copy link
Contributor

This update reverts the formatting on of chained functions as it broke filter strings, but at the same time leaves in a fix for extra spaces that the original issue found.

re #720, #704

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

This update reverts the formatting on of chained functions as it broke filter strings, but at the
same time leaves in a fix for extra spaces that the original issue found.

re #720, #704
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for djlint ready!

Name Link
🔨 Latest commit 2ba6e3b
🔍 Latest deploy log https://app.netlify.com/sites/djlint/deploys/64b918a17422cb00089963a8
😎 Deploy Preview https://deploy-preview-721--djlint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (41fa758) 95.38% compared to head (2ba6e3b) 95.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   95.38%   95.35%   -0.04%     
==========================================
  Files          16       16              
  Lines        1041     1033       -8     
  Branches      282      278       -4     
==========================================
- Hits          993      985       -8     
  Misses         34       34              
  Partials       14       14              
Impacted Files Coverage Δ
src/djlint/formatter/indent.py 98.55% <100.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christopherpickering christopherpickering merged commit bedab75 into master Jul 20, 2023
@christopherpickering
Copy link
Contributor Author

🎉 This PR is included in version 1.32.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant