지난 강의에서 누락된 구현 부분 수정하기 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
추상 클래스 필드의 접근 제어자로 `private`은 적절하지 않다. 강의 도중 POJO를 만든다고 의식하면서 실수한 듯. `protected`로 수정.
enum 필드는 jpa가 enum임을 이해할 수 있도록 추가 애노테이션을 필요로 함. 이를 설정, db 매핑 기준은 enum 원소 이름으로. 또한 작성 중에 `private` 위치를 실수한 듯. 수정함.
컬럼 not null 정보가 누락되었고, `AuditingFields`를 설명하면서 코드가 남아버렸다. 이를 수정함.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이 작업은 강의 도중 잘못 작성된 코드 일부를 수정한다.
This fixes #48