minor code cleanup

fixed possible memory leak

pkg/containerutil/save.go

@@ -8,8 +8,8 @@ import (
 )
 
 func Save(ctx context.Context, img v1.Image, dst, path string) error {
-	log := logr.FromContextOrDiscard(ctx)
-	log.Info("saving image to local file", "path", path)
+	log := logr.FromContextOrDiscard(ctx).WithValues("path", path, "dst", dst)
+	log.Info("saving image to local file")
 	if err := crane.Save(img, dst, path); err != nil {
 		log.Error(err, "failed to save image")
 		return err

pkg/lockfile/reader.go

@@ -20,6 +20,7 @@ func Read(ctx context.Context, cfgPath string) (*Lock, error) {
 		log.Error(err, "failed to open lockfile")
 		return nil, err
 	}
+	defer lock.Close()
 	// read the lockfile
 	var lockFile Lock
 	if err := json.NewDecoder(lock).Decode(&lockFile); err != nil {

pkg/lockfile/sha.go

@@ -5,10 +5,11 @@ import (
 	"encoding/hex"
 	"io"
 	"os"
+	"path/filepath"
 )
 
 func Sha256(path string) (string, error) {
-	f, err := os.Open(path)
+	f, err := os.Open(filepath.Clean(path))
 	if err != nil {
 		return "", err
 	}

pkg/yum/index.go

@@ -12,6 +12,7 @@ import (
 	"github.com/hashicorp/go-getter"
 	"net/http"
 	"os"
+	"path/filepath"
 	"strings"
 )
 
@@ -42,7 +43,7 @@ func NewIndex(ctx context.Context, repository string) (*yumindex.Metadata, error
 	if err := client.Get(); err != nil {
 		return nil, fmt.Errorf("downloading primary index: %w", err)
 	}
-	f, err := os.Open(dst)
+	f, err := os.Open(filepath.Clean(dst))
 	if err != nil {
 		return nil, fmt.Errorf("opening index: %w", err)
 	}