Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parser more robust against changes in the output of rustc #11

Closed
Kimundi opened this issue Mar 5, 2017 · 1 comment
Closed

Make parser more robust against changes in the output of rustc #11

Kimundi opened this issue Mar 5, 2017 · 1 comment

Comments

@Kimundi
Copy link
Collaborator

Kimundi commented Mar 5, 2017

Right now the parser of rustcs version information is relatively strict, expecting a clearly defined format of lines.

However, seeing how rustc is unlikely to break its output in a backwards-incompatible way, but might add additional fields (as has already happened in the past), it might be more forward-compatible to just look for the "<key>: <value>" lines this crate knows about and silently ignore the rest.
@alexcrichton
Copy link

FWIW this caused this change in rustc output to bounce in the past

@alexcrichton alexcrichton mentioned this issue Sep 24, 2018
Merged
alexcrichton added a commit to alexcrichton/rust-crc32fast that referenced this issue Dec 1, 2018
@alexcrichton
Drop dependency on rustc_version
a8339e7 
Unfortunately this has upstream bugs like djc/rustc-version-rs#11
which make the output non-robust in the face of changing rustc's output,
so switch to a more flexible manual implementation.
@alexcrichton alexcrichton mentioned this issue Dec 1, 2018
Merged
srijs pushed a commit to srijs/rust-crc32fast that referenced this issue Dec 1, 2018
@alexcrichton @srijs
Drop dependency on rustc_version
748869d 
Unfortunately this has upstream bugs like djc/rustc-version-rs#11
which make the output non-robust in the face of changing rustc's output,
so switch to a more flexible manual implementation.
alexcrichton added a commit to alexcrichton/rand that referenced this issue Dec 11, 2018
@alexcrichton
Move rustc_version dep to version_check
d084a89 
The `rustc_version` dependency is weighty and suffers from
djc/rustc-version-rs#11 which makes it more difficult to change
rustc over time.
@alexcrichton alexcrichton mentioned this issue Dec 11, 2018
Merged
alexcrichton added a commit to alexcrichton/rand that referenced this issue Dec 13, 2018
@alexcrichton
Move rustc_version dep to autocfg
e59539b 
The `rustc_version` dependency is weighty and suffers from
djc/rustc-version-rs#11 which makes it more difficult to change
rustc over time.
djc added a commit that referenced this issue Jan 11, 2021
@djc
Make parser more robust to input variations (fixes #11)
9447ae3
djc added a commit that referenced this issue Jan 11, 2021
@djc
Make parser more robust to input variations (fixes #11)
4fc3033
djc added a commit that referenced this issue Jan 11, 2021
@djc
Make parser more robust to input variations (fixes #11)
632def8
@djc djc closed this as completed in 2ba693d Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @Kimundi