Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_TOKEN per coveralls 3.3.1 help #45

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jombr
Copy link
Collaborator

@jombr jombr commented Mar 19, 2024

Getting the following error

Running on Github Actions but GITHUB_TOKEN is not set.
Add "env: GITHUB_TOEKN: ${{ secrets.GITHUB_TOKEN }}" to
your step config.

Following directions from latest coveralls python (3.3.1) help
for Github Actions
https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support

@jombr jombr requested a review from djc March 19, 2024 02:37
@coveralls
Copy link

coveralls commented Mar 19, 2024

Coverage Status

coverage: 88.963%. remained the same
when pulling 42ea74f on josephbredahl:coveralls-token-crash
into c70fbc1 on djc:main.

@jombr
Copy link
Collaborator Author

jombr commented Mar 19, 2024

@djc this seems to be the right or most popular answer. Let me know if you are OK with swapping using COVERALLS_REPO_TOKEN with the GITHUB_TOKEN.

Otherwise, I'm not really sure why COVERALLS_REPO_TOKEN wasn't working. I expect it should have been brought in via load_config_from_environment.

I couldn't quite verify if setting COVERALLS_REPO_TOKEN within the shell run: | no longer worked. So maybe doing something like...

env:
        COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}

... would still work.

...So I just defaulted to do what the coveralls-python help suggested. Figured that was the most safe path forward.

Also, let me know if you do or don't want me to bug you with reviews.

Getting the following error

   Running on Github Actions but GITHUB_TOKEN is not set.
   Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to
   your step config.
@jombr jombr merged commit 813bc86 into djc:main Mar 19, 2024
6 checks passed
@jombr jombr deleted the coveralls-token-crash branch March 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants