feat: cache token for GCloudAuthorizedUser #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation for
GCloudAuthorizedUser
is not caching the token got bygcloud auth print-access-token
. The token is valid for 60m but when using gcp_auth to run some service locally thegcloud
command is run for eachauth_manager.get_token(...)
call.This PR adds a
token: RwLock<Token>
inGCloudAuthorizedUser
just like other accounts that implementsServiceAccount
, also making the use cases more efficient when calling withauth_manager.get_token()
by usingGCloudAuthorizedUser
.Demo - effects when updated:
Before (
gcloud auth print-access-token
is run every time when using the managerget_token(...)
):After (token is cached):