Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing calls #843

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix parsing calls #843

merged 2 commits into from
Jul 31, 2023

Commits on Jul 31, 2023

  1. Fix parsing calls 

    This change:

* adds a cut when the leading `(` was encountered, and
* fixed the interaction between call expressions and boolean OR.
    @Kijewski
    Kijewski committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    818f452 View commit details
    Browse the repository at this point in the history

  2. Fix parsing arrays 

    This change

* allows using empty arrays `[]` in expessions,
* adds a cut when the leading `[` was encountered, and
* fixes the interaction between arrays and boolean OR.

IMO the restriction that you couldn't use empty arrays is not needed.
The missing cut made error messages slictly worse if you forget to add
the closing `]`.

Filter expressions must not have white spaces before the pipe `|`. The
white space is used to tell a filter expressions, and `std::ops::Or`
apart.
    @Kijewski
    Kijewski committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    17d40ad View commit details
    Browse the repository at this point in the history