Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the point of path based name? #5

Closed
dtolnay opened this issue Mar 6, 2017 · 3 comments
Closed

What is the point of path based name? #5

dtolnay opened this issue Mar 6, 2017 · 3 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented Mar 6, 2017

What is this useful for?

#[allow(dead_code, non_camel_case_types)]
type TemplateFromhello2ehtml<'a> = HelloTemplate<'a>;
@djc
Copy link
Owner

djc commented Mar 6, 2017

It was used for inheritance; because the inheriting template includes the path name. I guess now that the inheriting template has a mandatory _parent field, I guess this is no longer strictly necessary.

@dtolnay
Copy link
Contributor Author

dtolnay commented Mar 6, 2017

Yeah I understood the TraitFromhello2ehtml types in the context of inheritance but TemplateFrom never seemed to be used.

@djc djc closed this as completed in 0efd0c5 Mar 6, 2017
@djc
Copy link
Owner

djc commented Mar 6, 2017

Ah, is that what you meant! I iterated a bit on getting the inheritance right, this was necessary at some point, but no longer. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants