-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error after update to 4.4.1 (debug_toolbar.E001) The Django Debug Toolbar can't be used with tests #1920
Comments
Thank you. Yes, we should have also changed the installation instructions, sorry for that. You discovered the best way to do it. |
Fixes django-commons#1920. I thought about including the relevant documentation in the earlier steps, but I'd have to explain DEBUG, INTERNAL_IPS and TESTING all at once instead of introducing everything step by step. So even though it may be annoying to go back and modify code the user just added it still reads better to me, especially since it only applies to users running tests in their project. (I would hope a lot of them do, but still.)
Fixes django-commons#1920. I thought about including the relevant documentation in the earlier steps, but I'd have to explain DEBUG, INTERNAL_IPS and TESTING all at once instead of introducing everything step by step. So even though it may be annoying to go back and modify code the user just added it still reads better to me, especially since it only applies to users running tests in their project. (I would hope a lot of them do, but still.)
Fixes django-commons#1920. I thought about including the relevant documentation in the earlier steps, but I'd have to explain DEBUG, INTERNAL_IPS and TESTING all at once instead of introducing everything step by step. So even though it may be annoying to go back and modify code the user just added it still reads better to me, especially since it only applies to users running tests in their project. (I would hope a lot of them do, but still.)
To be clear, having |
@MarcoGlauser do you remember what you originally had for the |
Thank you all for responding so quickly to this :) While trying to figure out what changed yesterday, I created a reproduction: |
Ah, thank you! |
After upgrading to 4.4.1 we got an error when trying to run our tests, despite
DEBUG
beingFalse
:It took us a while to figure out what went wrong. It turns out the default installation method, recommended in the docs, doesn't work with the the changes from 4.4.0 (even if
DEBUG
isFalse
, which should deactivate Debug Toolbar)After some back and forth we figured out that the example directory configuration was the only way to run our tests:
The default installation docs are haven't changed for the 4.4.0 release and the example app is different than the recommended installation in the docs. Is this a missed docs update or an unintended breaking change?
The text was updated successfully, but these errors were encountered: