-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions #56
Conversation
@crydotsnake Tests are failing, please take a look. https://github.com/crydotsnake/djangocms-style/runs/2368782046?check_suite_focus=true |
Yeah requirements files are missing. I can't see actions from the github mobile app, but it told me alll as ok to merge. Clearly its not. 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requirements files missing
https://github.com/django-cms/djangocms-history/actions Here also i believe.. I think I was too fast.. |
Me to! Trying to quickly review from my phone 🤦♂️ |
@marksweb Thats interesting.. now i cant see the GitHub Action checks anymore in here. But i added the requirement files. |
They're running on your branch |
But before i saw the checks also here in the PR |
Okay. Glad the checks seems to be okay ! 😊 . Because i was not sure 🙈 |
I've looked at so many of these PRs now that I can't remember if they checks run before the merge. I'm assuming not, because they're not here, but your branch has them running and passing. |
No description provided.