Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #56

Merged
merged 6 commits into from
Apr 17, 2021
Merged

Add GitHub Actions #56

merged 6 commits into from
Apr 17, 2021

Conversation

crydotsnake
Copy link
Contributor

No description provided.

@vinitkumar
Copy link
Member

@marksweb
Copy link
Sponsor Member

@crydotsnake Tests are failing, please take a look. https://github.com/crydotsnake/djangocms-style/runs/2368782046?check_suite_focus=true

Yeah requirements files are missing. I can't see actions from the github mobile app, but it told me alll as ok to merge. Clearly its not. 🤦‍♂️

Copy link
Sponsor Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements files missing

@crydotsnake
Copy link
Contributor Author

https://github.com/django-cms/djangocms-history/actions Here also i believe..

I think I was too fast..

@marksweb
Copy link
Sponsor Member

https://github.com/django-cms/djangocms-history/actions Here also i believe..

I think I was too fast..

Me to! Trying to quickly review from my phone 🤦‍♂️

@crydotsnake
Copy link
Contributor Author

@marksweb Thats interesting.. now i cant see the GitHub Action checks anymore in here. But i added the requirement files.

@marksweb
Copy link
Sponsor Member

@marksweb Thats interesting.. now i cant see the GitHub Action checks anymore in here. But i added the requirement files.

They're running on your branch

https://github.com/crydotsnake/djangocms-style/actions

@crydotsnake
Copy link
Contributor Author

But before i saw the checks also here in the PR

@crydotsnake
Copy link
Contributor Author

crydotsnake commented Apr 17, 2021

Okay. Glad the checks seems to be okay ! 😊 . Because i was not sure 🙈

@marksweb
Copy link
Sponsor Member

Okay. Glad the checks seems to be okay ! 😊 . Because i was not sure 🙈

I've looked at so many of these PRs now that I can't remember if they checks run before the merge. I'm assuming not, because they're not here, but your branch has them running and passing.

@vinitkumar vinitkumar merged commit ca364f1 into django-cms:master Apr 17, 2021
@fsbraun fsbraun mentioned this pull request Dec 6, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants