Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

build(deps): bump hashicorp/http from 2.1.0 to 2.2.0 in /terraform #1724

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 6, 2022

Bumps hashicorp/http from 2.1.0 to 2.2.0.

Release notes

Sourced from hashicorp/http's releases.

v2.2.0

ENHANCEMENTS:

  • data-source/http: body is now deprecated and has been superseded by response_body. body will be removed in the next major release (#137).

NOTES:

  • "Uplift" aligned with Utility Providers Upgrade (#135).
Changelog

Sourced from hashicorp/http's changelog.

2.2.0 (June 02, 2022)

ENHANCEMENTS:

  • data-source/http: body is now deprecated and has been superseded by response_body. body will be removed in the next major release (#137).

NOTES:

  • "Uplift" aligned with Utility Providers Upgrade (#135).
Commits
  • 186887f Deprecating body and replacing with response_body (#137)
  • a9a1d6e Bump github.com/hashicorp/terraform-plugin-docs from 0.8.1 to 0.9.0 (#139)
  • 4ceddbe Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0 (#138)
  • fff9b1c Utility Providers Upgrade (#136)
  • 2f9d744 Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.15.0 to 2.16.0 (#134)
  • 8395d3f RelAPI Onboarding (#126)
  • 1d54e1f Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.14.0 to 2.15.0 (#133)
  • 7db405c Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.13.0 to 2.14.0 (#132)
  • 1c1a3d2 Bumping go version specified in workflows, .go-version and README (#131)
  • 3336a1a .github/workflows: Fix waiting-response label removal (#84)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [hashicorp/http](https://github.com/hashicorp/terraform-provider-http) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/hashicorp/terraform-provider-http/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-http/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-http@v2.1.0...v2.2.0)

---
updated-dependencies:
- dependency-name: hashicorp/http
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner June 6, 2022 09:22
@dependabot dependabot bot added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code labels Jun 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #1724 (014f3d9) into main (6d18ae5) will decrease coverage by 18.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1724       +/-   ##
===========================================
- Coverage   59.72%   40.94%   -18.78%     
===========================================
  Files          37        5       -32     
  Lines        8846      889     -7957     
===========================================
- Hits         5283      364     -4919     
+ Misses       3448      498     -2950     
+ Partials      115       27       -88     
Flag Coverage Δ
facilitator_tests ?
key_rotator_tests ?
workflow_manager_tests 40.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
facilitator/src/http.rs
facilitator/src/bin/facilitator.rs
key-rotator/storage/key_aws.go
facilitator/src/aws_credentials.rs
facilitator/src/task.rs
key-rotator/storage/key_gcp.go
facilitator/src/manifest.rs
key-rotator/storage/key_k8s.go
facilitator/src/logging.rs
facilitator/src/transport/gcs.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d18ae5...014f3d9. Read the comment docs.

@divergentdave
Copy link
Contributor

I added a commit to replace our uses of the deprecated attribute.

I wasn't able to get Terraform to output any deprecation warnings, after upgrading to http 2.2.0 and before removing .body uses. I may be missing something, but this could be a bug in Terraform. See below for a minimal example, I also don't see any deprecation warnings with this.

terraform {
  backend "local" {}
  required_version = ">1.1.0"
  required_providers {
    http = {
      source  = "hashicorp/http"
      version = "2.2.0"
    }
    local = {
      source = "hashicorp/local"
      version = "2.2.3"
    }
  }
}

data "http" "test" {
  url = "https://httpbin.org/get"
}

locals {
  my_local = data.http.test.body
}

resource "local_file" "my_local_file" {
  content = data.http.test.body
  filename = "${path.module}/out.txt"
}

@divergentdave
Copy link
Contributor

It appears that, while attributes can be marked as Deprecated, there are no mechanisms to produce a deprecation warning when such attributes are used. See hashicorp/terraform#7569. Only arguments currently get deprecation warnings.

@divergentdave divergentdave merged commit 469e9d0 into main Jun 13, 2022
@divergentdave divergentdave deleted the dependabot/terraform/terraform/hashicorp/http-2.2.0 branch June 13, 2022 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants