Align Aggregator trait with spec
#744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Vdaf::prepare_preprocess` was missing the `&Vdaf::AggregationParam` argument specified in VDAF. This adds that argument to the trait method and its implementations. While we're at it, to further align with the spec, we add new methods `prepare_shares_to_prepare_message` and `prepare_next`, to align with the spec's `prep_shares_to_prep` and `prep_next`, as aliases for the existing `prepare_preprocess` and `prepare_step`. The existing methods are marked as deprecated. Resolves #670
branlwyd
approved these changes
Sep 11, 2023
| /// specification. | ||
| /// | ||
| /// [VDAF]: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-vdaf-07#section-5.2 | ||
| #[deprecated( |
There was a problem hiding this comment.
IMO, since this PR will be part of an effective-major-version bump, we may as well just drop the old methods. Backwards compatibility is not a concern, and if we keep these methods we'll need to keep them until the next effective-major-version bump.
There was a problem hiding this comment.
This way it's easier to give people a hint of what to move to. Filed #745 to remove them later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vdaf::prepare_preprocesswas missing the&Vdaf::AggregationParamargument specified in VDAF. This adds that argument to the trait method and its implementations. While we're at it, to further align with the spec, we add new methodsprepare_shares_to_prepare_messageandprepare_next, to align with the spec'sprep_shares_to_prepandprep_next, as aliases for the existingprepare_preprocessandprepare_step. The existing methods are marked as deprecated.Resolves #670