Plumb Prio3Aes128CountVec VDAF throughout Janus
#480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
force-pushed
the
timg/prio3-aes128-count-vec
branch
2 times, most recently
from
ba64b83 to
fc3e0df
Compare
branlwyd
approved these changes
Sep 8, 2022
| @@ -220,6 +220,13 @@ impl<C: Clock + 'static> AggregationJobCreator<C> { | |||
| .await | |||
| } | |||
|
|
|||
| crate::task::VdafInstance::Real(janus_core::task::VdafInstance::Prio3Aes128CountVec { .. }) => { | |||
There was a problem hiding this comment.
not caused by this PR: consider importing crate::task::VdafInstance so the match arms can be written as VdafInstance::Real(...) as they are in other instances of this kind of match.
divergentdave
approved these changes
Sep 9, 2022
tgeoghegan
force-pushed
the
timg/prio3-aes128-count-vec
branch
from
fc3e0df to
85c2894
Compare
Adds support to Janus for an extra VDAF. Also plumbs it into the interop test API, which required allowing the representation of vectors of numbers to a `Measurement`, and unconditionally representing numbers as strings to avoid JSON number precision problems. A change to draft-dcook-ppm-dap-interop-test-design will follow to update the language describing how to encode measurements and aggregate results. Resolves #478
tgeoghegan
force-pushed
the
timg/prio3-aes128-count-vec
branch
from
85c2894 to
64df1f1
Compare
|
Corresponding change to the interop test spec: divergentdave/draft-dcook-ppm-dap-interop-test-design#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to Janus for an extra VDAF. Also plumbs it into the interop
test API, which required allowing the representation of vectors of
numbers to a
Measurement, and unconditionally representing numbers asstrings to avoid JSON number precision problems. A change to
draft-dcook-ppm-dap-interop-test-design will follow to update the
language describing how to encode measurements and aggregate results.
Resolves #478