Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Daphne in use for tests. #432

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Build Daphne in use for tests. #432

merged 3 commits into from
Aug 25, 2022

Conversation

branlwyd
Copy link
Contributor

Also, update Daphne to the latest version.

@branlwyd
Update Daphne to latest commit.
a348661 
This is an intermediate commit before we check out & build Daphne as
needed.
@branlwyd branlwyd force-pushed the bran/build-daphne branch 2 times, most recently from 936578f to e4eba0c Compare August 24, 2022 19:14
@branlwyd
Build Daphne for tests.
37544b3 
Now, rather than using a pre-compiled version of Daphne that we build
into a conatiner using our own custom build process, we build & use the
Daphne test container defined in the Daphne repository itself.
@branlwyd branlwyd marked this pull request as ready for review August 24, 2022 19:16
@branlwyd branlwyd requested a review from a team as a code owner August 24, 2022 19:16
@branlwyd
Copy link
Contributor Author

OK, this is ready for review.

@branlwyd
Copy link
Contributor Author

A few notes:

  • My next step in this line of work is going to be doing the work to allow a prebuilt Daphne container to be used, and to use one in practice for CI & make it easy for us to use prebuilt Daphne on our local machines.
  • Sadly, the aggregator-endpoint path issue we ran into in our deployment would have been caught by the integration test -- but no one ran them on a version that includes the issue. (This doesn't matter much since our current deployments are test-only, but IMO this highlights the importance of maintaining strong tests.)

@branlwyd branlwyd mentioned this pull request Aug 25, 2022
Merged
@branlwyd branlwyd merged commit e842b61 into main Aug 25, 2022
@branlwyd branlwyd deleted the bran/build-daphne branch August 25, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@branlwyd @divergentdave