Drop support for older DAP protocol versions #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
approved these changes
Jul 17, 2024
|
The cli crate mostly drafts off of the changes in the client crate. The only protocol version-aware logic is in the dap-client subcommand, and that doesn't change because it only supports draft-09. I thought about cleaning up feature logic, but reconsidered because that may make integration with third-party (non-Janus) aggregators harder in the medium- to long-term. At any rate, we can still simplify it in a follow-up PR. |
branlwyd
approved these changes
Jul 17, 2024
divergentdave
force-pushed
the
david/drop-old-dap-versions
branch
from
d210d70 to
bb0ae12
Compare
divergentdave
force-pushed
the
david/drop-old-dap-versions
branch
from
bb0ae12 to
b5f174f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for DAP draft-04 and draft-07 protocol versions, and eliminates some protocol-version-dependent logic.