make core an unecessary profile and add to suites #229
Conversation
lib/devos/mkHosts.nix
Outdated
| @@ -49,6 +49,11 @@ let | |||
| override.flake = inputs.override; | |||
| }; | |||
|
|
|||
| nix.allowedUsers = [ "@wheel" ]; | |||
| nix.trustedUsers = [ "root" "@wheel" ]; | |||
There was a problem hiding this comment.
- Is there a guarantee for root to exist? 2. Does it matter?
- Does this need to be here?
There was a problem hiding this comment.
I believe root is necessary for a nixos system, I could be wrong.
But that could go in the core profile, I'm not against that. devos would work fine without those lines.
The separation I did was fairly opinionated, and I've always had those lines in my hosts, so I thought it would make sense to include in mkHosts.
There was a problem hiding this comment.
IIRC, @nrdxp did not have root in his config?
There was a problem hiding this comment.
Ok I'll just put this back in the core profile. It is definitely not needed, I guess I didn't think there would be a reason to not include it. But you have proved me wrong :).
Pacman99
force-pushed
the
corereq-hosts
branch
2 times, most recently
from
b370e78 to
b648e20
Compare
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
Build failed: |
Prevents mkHosts subverting standard devos api to import core and add all necessary core features to mkHosts, so core can be safely deleted in suites
|
bors r+ |
|
👎 Rejected by too few up-to-date approved reviews (some of the PR reviews are stale) |
|
👎 Rejected by too few up-to-date approved reviews (some of the PR reviews are stale) |
|
Build succeeded: |
Prevents mkHosts subverting standard devos api to import core and add
all necessary core features to mkHosts, so core can be safely deleted in
suites