Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: begin work on new documentation #113

Merged
merged 4 commits into from
Feb 15, 2021
Merged

doc: begin work on new documentation #113

merged 4 commits into from
Feb 15, 2021

Conversation

nrdxp
Copy link
Collaborator

@nrdxp nrdxp commented Feb 7, 2021

The scope of this PR has been reduced, and doesn't complete #111, but only partially implements it.

Essentially, each subdirectory will contain it's own README.md file explaining the purpose and usage of said directory. In additional,all of the md files will be compiled together in an mdbook which willbe rendered and hosted on github pages.

The rendered mdbook can be viewed on my website. https://nrdxp.dev/nixflk

@nrdxp nrdxp force-pushed the doc branch 6 times, most recently from 4fee78f to 100dc40 Compare February 7, 2021 04:14
@blaggacao
Copy link
Contributor

blaggacao commented Feb 9, 2021

Congrats! This is getting very nice! I'm considering adding paperback support soonish to nixpkgs (for purely nostalgic reasons) 😉

It might be slightly advantageous to put layout markdown files directly alongside the respectifv nix files within the folder layout. This way, the md doc is directly available next to the relevant files (for example also for browsing git).

It is possible to put book.toml on the top level and then do:

[book]
src = "."

... and then just reference the files normaly from root.

→ the quickstart, parts of the readme content, etc obviously could continue to live in the ./doc folder under such scenario as there is no more "native" place.

Another advantage is that it would get very straight forward for users to expand with their own documentation, for example for a specific profiles, etc. (Taking the sharing aspect to the next level).

Just my 2 cents. 👍

@Pacman99
Copy link
Member

I've read through the entire thing and it looks really great! I think it is very clear and easy to understand.

It might be slightly advantageous to put layout markdown files directly alongside the respectifv nix files within the folder layout. This way, the md doc is directly available next to the relevant files (for example also for browsing git).

I would personally prefer this. It would be simpler and easy to contribute to. But I could see it being harder for you to maintain.

@nrdxp
Copy link
Collaborator Author

nrdxp commented Feb 11, 2021

Sounds like a good idea. Still have a lot of work to do here, so I'll give it a shot and see how it goes.

@nrdxp nrdxp force-pushed the doc branch 2 times, most recently from da77533 to 6751c09 Compare February 14, 2021 02:23
@nrdxp
Copy link
Collaborator Author

nrdxp commented Feb 14, 2021

force pushed, with layout section done, and everything squashed into a single commit.

@nrdxp nrdxp mentioned this pull request Feb 14, 2021
10 tasks
Users may wish to change the default value of override and nixos
inputs. If they do so, we want the registry listing to reflect the
proper ref names afterwards.

Also create a shell alias to easily search every flake in nix.registry.
@nrdxp
Copy link
Collaborator Author

nrdxp commented Feb 15, 2021

I'm gonna go ahead and push this to core even though all the goals from #111 have not been reached. What we have so far will be immensely helpful for new users, and I'd like to get it in front of them right away. We will finish the issue with an additional PR in the future.

@nrdxp nrdxp merged commit b54e5e6 into core Feb 15, 2021
@nrdxp nrdxp deleted the doc branch February 15, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants