-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiration date update #3597
Expiration date update #3597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deployed from this branch, and it doesn't seem to fix the problem for me. I still lose focus on the first click...
Screencast.from.2024-01-10.09-14-01.webm
dashboard/src/modules/components/OverviewComponent/SavedRunsComponent.jsx
Show resolved
Hide resolved
1090868
to
f3842f6
Compare
Since you'd done a rebase on this branch a few days ago, I'd been meaning to get around to pulling the branch to check whether it was working now; and I'm still seeing the same behavior. The focus doesn't stick, and the calendar picker doesn't actually change the date. Could this be related to Webb's comment about the dispatch behavior? Or is something else going wrong? And, is this only me (and perhaps Chrome)? Is it working for you? (FYI, I did a full |
e5ad06c
to
e66e567
Compare
As there were problems with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once Dave's concern has been addressed, I'm good with this merging, with the expectation that the fix to the other problem will come in its own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Varshini wants to fix the to/update problem separately, so let's go.
PBECNH-1311
Expiration date update