Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization page not loading #3596

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Visualization page not loading #3596

merged 4 commits into from
Jan 22, 2024

Conversation

MVarshini
Copy link
Contributor

PBENCH-1314

Visualization page not loading

@MVarshini MVarshini added the Dashboard Of and relating to the Dashboard GUI label Jan 10, 2024
@MVarshini MVarshini requested a review from dbutenhof January 10, 2024 11:17
@MVarshini MVarshini self-assigned this Jan 10, 2024
dbutenhof
dbutenhof previously approved these changes Jan 10, 2024
View reviewed changes
webbnh
webbnh reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with this change...other than to ask whether it is necessary (i.e., does it actually fix anything, and, if so, wouldn't it be better, instead of handling undefined entries, to ensure that there are none in the list to begin with?). (That is, are we papering over some deeper problem?)

@MVarshini MVarshini requested review from dbutenhof and webbnh January 19, 2024 13:51
webbnh

This comment was marked as resolved.

Sign in to view

@webbnh
Copy link
Member

webbnh commented Jan 19, 2024

I would still like to understand how we could be getting undefined values for item inside the filter.

OK, here's the answer: "Arrays can contain 'empty slots', which are not the same as slots filled with the value undefined."

So, apparently our array of datasets has some entries which have actually been set to undefined. That's...disquieting.

@MVarshini MVarshini dismissed stale reviews from webbnh and dbutenhof via 686a0eb January 22, 2024 11:32
webbnh
webbnh approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@webbnh webbnh merged commit 01ce14d into distributed-system-analysis:main Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@webbnh webbnh webbnh approved these changes

Assignees

@MVarshini MVarshini

Labels
Dashboard Of and relating to the Dashboard GUI
Projects
v0.72
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MVarshini @webbnh @dbutenhof