Visualization Page Pagination #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVarshini
force-pushed
the
PBENCH-1300
branch
2 times, most recently
from
b4e6beb to
0a5f2bd
Compare
dbutenhof
previously approved these changes
Jan 2, 2024
webbnh
reviewed
Jan 2, 2024
There was a problem hiding this comment.
While I concur with Dave, I don't think we should be committing commented-out code (if that's what that is...), and I think it would be better if we simplified the dispatch-to-dispatch pattern...but, I'm not blocking the merge if you two think this should move forward as-is.
dashboard/src/modules/components/ComparisonComponent/PanelContent.jsx
Outdated
Show resolved
Hide resolved
dbutenhof
approved these changes
Jan 3, 2024
webbnh
pushed a commit
that referenced
this pull request
Jan 4, 2024
* PBENCH-1300 Visualization Page Pagination
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1300
Visualization Page Pagination