Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort datasets by uploaded time #3588

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

MVarshini
Copy link
Contributor

PBENCH-1306

Sort datasets by uploaded time

@MVarshini MVarshini added the Dashboard Of and relating to the Dashboard GUI label Dec 19, 2023
@MVarshini MVarshini added this to the v0.73 milestone Dec 19, 2023
@MVarshini MVarshini requested a review from webbnh December 19, 2023 07:01
@MVarshini MVarshini self-assigned this Dec 19, 2023
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try this out, but addParams() is a fairly low-level function, and I'm afraid that this may have unintended consequences. I suspect that the requested sort order parameter should be added at a higher level in the call stack.

That is, I think that this does exactly what we want for the "new results" list but not necessarily what we want for the "saved results" list, and I believe that there are several other places where this change will have an effect (on the Results and Visualization pages, e.g.). And, I'm wondering if this will break pagination if a new result is uploaded (e.g., if one user is looking at the Results page and another user uploads a new public result, then the "next" page will be off by one result (because all of the results would have been shifted "down" by one when the new result is added ot the "top"), probably resulting in a dataset being listed twice).

Sort datasets by uploaded time
@dbutenhof dbutenhof merged commit e894edb into distributed-system-analysis:main Jan 2, 2024
4 checks passed
webbnh pushed a commit that referenced this pull request Jan 4, 2024
Sort datasets by uploaded time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Of and relating to the Dashboard GUI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants