Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new NPM packaging workaround; remove the previous one #3017

Merged

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Sep 23, 2022

Once again our build was broken by an external update to an NPM package. Happily, they were quick to fix it, so it's no longer necessary for us to work around the problem.

However, this PR commits the residue from that effort:

  • First, we remove the workaround from the last time we had this firedrill, since it's no longer necessary.
  • Second, we add a stub structure to hold the override for the next time (so we don't have to re-remember how to do it). (The form is different from the last time, because we're now running a current version of npm which supports it.)

@webbnh webbnh added Code Infrastructure Dashboard Of and relating to the Dashboard GUI labels Sep 23, 2022
@webbnh webbnh added this to the v0.71.1 milestone Sep 23, 2022
@webbnh webbnh self-assigned this Sep 23, 2022
@webbnh webbnh force-pushed the next-npm-workaround branch from 136e523 to 93a763d Compare September 23, 2022 22:00
@webbnh webbnh marked this pull request as ready for review September 23, 2022 22:02
Leave a stub structure to house the next workaround when needed.
@webbnh webbnh force-pushed the next-npm-workaround branch from 93a763d to 7524064 Compare September 24, 2022 00:08
@portante portante modified the milestones: v0.71.1, v0.72 Sep 24, 2022
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...

@portante
Copy link
Member

Added the "DO NOT MERGE!!!" label until @MVarshini has had a chance to review and sign off.

Copy link
Contributor

@MVarshini MVarshini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@portante portante merged commit bd589af into distributed-system-analysis:main Sep 27, 2022
@webbnh webbnh deleted the next-npm-workaround branch September 27, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Infrastructure Dashboard Of and relating to the Dashboard GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants