Using redux-beacon for GTM event handling #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungeric
requested review from
falconmick,
markmollart,
samlogan and
AllanPooley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using redux-beacon for Google Tag Manager event handling
I've replaced Michael's custom implementation for Google Tag Manager event handling (in app/utils/gtmMiddleware.js) with redux-beacon which simplifies the code a lot and should make it easier to maintain and add more events to future builds.
I've brought over some things from Absolute Cosmetic's code to get the trackingId from App Settings and also replaced the Google Analytics snippet with the Google Tag Manager snippet.
This should also add the GTM scripts/snippets in the right places on the DOM when you add a GTM Tracking ID in the App Settings in WordPress.
Hoping this PR will help standardise the GTM scripts positioning as well.