test: decouple test components from httpx #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've moved away from the built-in test server in favor of pushing users towards using the CLI. The CLI sets environment variables, so there's no chance of user error which is what these messages were designed to help with. Eliminating the httpx dependency means we can adapt the test package to other web frameworks/clients.
Pryz
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test components we offer in the
dispatch.testpackage were coupled to thehttpxpackage, since this is what FastAPI uses internally (e.g. for its test client).To be able to test other web frameworks (e.g.
flaskfrom #169), we need to decouple our test components from FastAPI and httpx.This PR does just that, by using a protocol (i.e. structural typing) for the HTTP client and response.
I've downgraded
httpxto a dev dependency as a result.