Fix refined newtypes #1595
Merged
Fix refined newtypes #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Sep 26, 2024
| @@ -202,9 +202,14 @@ private[smithy4s] trait LowPriorityImplicits { | |||
| : RefinementProvider[Pattern, E, E] = | |||
| new RefinementProvider.PatternConstraint[E](e => e.value) | |||
|
|
|||
| implicit def isomorphismConstraint[C, A, A0](implicit | |||
| @deprecated("Use isomorphismConstraint2 instead", "0.18.25") | |||
There was a problem hiding this comment.
thought: for bincompat, we have to keep the old method.
There was a problem hiding this comment.
I tried to make it private[smithy4s] but MiMa complained about the static forwarder disappearing. Figured I'd restore the method to the public scope, it doesn't hurt if it's not implicit anymore.
Baccata
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1594.
PR Checklist (not all items are relevant to all PRs)