Quick attempt at resolving AWS signing problems (#1568, #1532)

disneystreaming · Sep 27, 2024 · cac1af5 · cac1af5
1 parent b828a13
commit cac1af5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/modules/aws-http4s/src/smithy4s/aws/AwsClient.scala b/modules/aws-http4s/src/smithy4s/aws/AwsClient.scala
@@ -71,7 +71,11 @@ object AwsClient {
 
       def baseRequest(endpoint: OperationSchema[_, _, _, _, _]): F[HttpRequest[Blob]] = {
         awsEnv.region.map { region =>
-          val endpointPrefix = awsService.endpointPrefix.getOrElse(endpoint.id.name)
+          val endpointPrefix =
+            awsService.endpointPrefix
+              .orElse(awsService.arnNamespace.map(_.value))
+              .getOrElse(endpoint.id.name)
+
           val baseUri = HttpUri(
             scheme = HttpUriScheme.Https,
             host = s"$endpointPrefix.$region.amazonaws.com",

diff --git a/modules/aws-http4s/src/smithy4s/aws/internals/AwsSigning.scala b/modules/aws-http4s/src/smithy4s/aws/internals/AwsSigning.scala
@@ -60,7 +60,10 @@ private[aws] object AwsSigning {
   ): Client[F] => Client[F] = {
     val endpointPrefix = serviceHints
       .get(_root_.aws.api.Service)
-      .flatMap(_.endpointPrefix)
+      .flatMap { awsService =>
+        awsService.endpointPrefix
+          .orElse(awsService.arnNamespace.map(_.value))
+      }
       .getOrElse(serviceId.name)
       .toLowerCase()