Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rudimentary Windows sanity check #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rudimentary Windows sanity check #97

wants to merge 1 commit into from

Conversation

xaduha
Copy link

@xaduha xaduha commented Feb 11, 2021

No description provided.

Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of a basic sanity check, but I don't think it belongs here this way. I think we should use the matrix capabilities of Github Actions and have a job that does a sanity check across all of the OSes. Something added to ci.yaml like:

  sanity:
     name: Smoke Test Sanity Check
    strategy:
      matrix:
        os: [darwin, windows, linux]
     steps:
    - name: checkout
      uses: actions/checkout@v2
    - uses: actions/setup-go@v2
      with:
        go-version: '1.15.7' # The Go version to download (if necessary) and use.
    - run: GOOS=${{ matrix.os }} go build

I might have gotten that a bit wrong, but that is the general idea.

@rpunt rpunt mentioned this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants