implement remove and rename feature for fat32 #233
Conversation
ludelion5
changed the title
There was a problem hiding this comment.
Overall, this looks great, and thank you.
In terms of naming, are these meant to be restricted just to files, or any structure (files, dirs, symlinks where supported, etc.)? I would think the latter, since CLI-level commands for the above in most OSes don't care. Same for linux mv / Windows ren.
So should these be RemoveFile() and RenameFile(), or just Remove() and Rename()?
On the other hand, in keeping with golang style, maybe these should parallel and be Remove() and RemoveAll() and [Rename()](https://pkg.go.dev/os#Rename]?
|
Thanks for the feedback. I will look into your request and test, if the implementation will also work for symlinks and directories. If so, its a good idea to stick to your suggested naming-scheme. Additionally I can check if the RemoveAll is easy to implement, I have to see if I can spare enough time for that feature. |
Sorry for the late PR. Here is my proposal to rename and remove files in fat32.
closes #191