Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to remove files #191

Open
ludelion5 opened this issue Dec 8, 2023 · 3 comments · May be fixed by #233
Open

Support to remove files #191

ludelion5 opened this issue Dec 8, 2023 · 3 comments · May be fixed by #233

Comments

@ludelion5
Copy link

Hi, thanks for the awesome library.

I played around a bit with the library and was able to create new files and upate existing files on a fat32 partition inside an image. Unfortunately, there seems to be no support for removing files. Do I miss something? If its really missing, will the remove functionality come in the future?

Thanks and best regards

@deitch
Copy link
Collaborator

deitch commented Dec 11, 2023

Right you are. Never got to implementing delete. Of course, some filesystems are read-only (iso and squashfs), so that would fail. And it supports mkdir and creating files and modifying partition tables on disks. But, yes, deleting never got created.

A contribution would be most welcome.

@ludelion5
Copy link
Author

Sorry for the late response, in the meantime I have implemented a remove and renaming feature supported by unit-tests. The patch-file was submitted to our open-source department in my company and will be checked, they will open a pull-request for you to review. Unfortunately, this might take some time. Hopefully everything works out and we can contribute to your library :-)

@deitch
Copy link
Collaborator

deitch commented Mar 5, 2024

That would be great, thank you. I am sorry you have to go through the approvals rigamarole, but it isn't uncommon in large firms.

@ludelion5 ludelion5 linked a pull request Jul 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants