bug: fix hang when last element in stream takes a long time to process #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stream reader assumed there would be a gap between processing the last element in a list & the stream finishing (end event). This is not always the case - the last element could have an async component or be a very large object which takes a long time to process. This PR adds an explicit 'ended' flag to the stream node so the parser knows if the stream has actually ended. Fixes discoveryjs#8
|
Looks good. Thank you! |
|
Fix published in v0.5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream reader assumed there would be a gap between processing the last element in a list & the stream finishing (end event).
This is not always the case - the last element could have an async component or be a very large object which takes a long time to process.
This PR adds an explicit 'ended' flag to the stream node so the parser knows if the stream has actually ended.
Fixes #8