fix(WebSocketShard): clear listeners on reconnect #8927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
DraftProducts
approved these changes
Dec 14, 2022
SpaceEEC
approved these changes
Dec 14, 2022
kyranet
approved these changes
Dec 14, 2022
vladfrangu
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR should solve resolve #8486 and maybe even resolve #8592
When a WebSocketShard doesn't receive a heartbeat in time it tries to close the Websocket. If the close event of the socket doesn't emit in time either it assumes a zombie connection and emits its own close event, but the old connection still has the onClose and other event listeners attached. So if the old Websocket finally emits the close event the WebSocketShard receives that event and assumes it's from the new (re-)connection and closes again.
Status and versioning classification: