Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings(Embed): add missing getters and add video to EmbedData #7728

Merged
merged 4 commits into from
Apr 12, 2022
Merged

typings(Embed): add missing getters and add video to EmbedData #7728

merged 4 commits into from
Apr 12, 2022

Conversation

BaumianerNiklas
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR adds the author getter to the Embed typings which was previously missing.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

vladfrangu
vladfrangu approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check nothing else is missing? LGTM otherwise

@BaumianerNiklas
Copy link
Contributor Author

Whoops yeah, looks like there are still some other fields missing (specifically hexColor, video, provider and length). I'll add these shortly

@BaumianerNiklas
Copy link
Contributor Author

I've now added the getters for hexColors, provider and length, but I don't know what to do about video. There is no EmbedVideoData interface in index.d.ts, I can't find the typedef mentioned here, and a video field also doesn't exist on EmbedData. Should it be removed from Embed, or should it be added to Embed and EmbedData? The Discord API docs do say that it exists.

@suneettipirneni
Copy link
Member

I've now added the getters for hexColors, provider and length, but I don't know what to do about video. There is no EmbedVideoData interface in index.d.ts, I can't find the typedef mentioned here, and a video field also doesn't exist on EmbedData. Should it be removed from Embed, or should it be added to Embed and EmbedData? The Discord API docs do say that it exists.

If it doesn't currently exist you can go ahead and define it.

@BaumianerNiklas BaumianerNiklas changed the title typings(Embed): add missing author getter typings(Embed): add missing getters and add video to EmbedData Apr 4, 2022
@kyranet
Copy link
Member

kyranet commented Apr 10, 2022 •
edited
Loading

There are merge conflicts, please update or rebase your branch.

@iCrawl iCrawl added this to the discord.js v14 milestone Apr 12, 2022
@iCrawl iCrawl merged commit fd1dc72 into discordjs:main Apr 12, 2022
@BaumianerNiklas BaumianerNiklas deleted the fix/types-embed-add-author branch April 12, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@bilgehanertan bilgehanertan bilgehanertan approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.
7 participants
@BaumianerNiklas @suneettipirneni @kyranet @vladfrangu @iCrawl @SpaceEEC @bilgehanertan