Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(InteractionCollector): simplify constructor logic #7667

Merged
merged 2 commits into from
Mar 24, 2022
Merged

refactor(InteractionCollector): simplify constructor logic #7667

merged 2 commits into from
Mar 24, 2022

Conversation

muchnameless
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Message#channel and Message#guild are getters which use Message#channelId and Message#guildId internally, so there is no need to invoke them and use resolveId
the empty method is currently bound for each IntereactionCollector even though it is not used in any listener, probably a copy-paste from ReactionCollector

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit 07b23a9 into discordjs:main Mar 24, 2022
@muchnameless muchnameless deleted the refactor-InteractionCollector branch March 24, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants