refactor(embed): allow hex strings in setColor()
#7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
ImRodry
reviewed
Mar 4, 2022
suneettipirneni
force-pushed
the
discord.js/refactor/allow-string-colors
branch
from
a210304 to
b38e072
Compare
ImRodry
reviewed
Mar 4, 2022
ImRodry
reviewed
Mar 4, 2022
suneettipirneni
force-pushed
the
discord.js/refactor/allow-string-colors
branch
from
b38e072 to
070a3b1
Compare
iCrawl
approved these changes
Mar 4, 2022
vladfrangu
approved these changes
Mar 4, 2022
suneettipirneni
force-pushed
the
discord.js/refactor/allow-string-colors
branch
from
070a3b1 to
000a693
Compare
SpaceEEC
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Originally I had assumed hex number literals would suffice over hex strings. However, many external services may return colors as hex strings because it's a popular format. This PR allows hex strings to be passed into
setColorfor discord.js embed builders.Status and versioning classification: