Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(anychannel): add PartialGroupDMChannel #7472

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Feb 16, 2022

Please describe the changes this PR makes and why it should be merged:

This fixes a bug with Channel#isDMBased() where it wouldn't correctly infer that a channel isn't a group DM

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@kyranet
Copy link
Member

kyranet commented Feb 16, 2022

Tests need to be updated according to CI's logs:

discord.js:test: typings/index.test-d.ts(951,51): error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'undefined'.
discord.js:test:   Type 'null' is not assignable to type 'undefined'.

@ImRodry
Copy link
Contributor Author

ImRodry commented Feb 16, 2022

Yeah I know, my bad, I didn’t see the error when committing and haven’t had time to fix since. Will do later today

@ImRodry ImRodry force-pushed the types/fix-anychannel-groupdm branch from c999981 to b6f62c3 Compare February 16, 2022 19:18
@ImRodry ImRodry changed the title types(anychannel): replace PartialDMChannel with group DM types(anychannel): add PartialGroupDMChannel Feb 16, 2022
@ImRodry ImRodry force-pushed the types/fix-anychannel-groupdm branch from 4c944cd to 5ea16f7 Compare February 20, 2022 12:43
@iCrawl iCrawl merged commit cf66930 into discordjs:main Feb 23, 2022
@ImRodry ImRodry deleted the types/fix-anychannel-groupdm branch February 26, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants