Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use case converter for json component serialization #7464

Merged
merged 9 commits into from
Feb 16, 2022
Merged

fix: use case converter for json component serialization #7464

merged 9 commits into from
Feb 16, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Feb 14, 2022 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Fixes a bug where components that were converted snake case would have their properties overwritten with undefined when spreading.

Note: this library has been tested against strings like URL and it serializes it into snake case properly.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni suneettipirneni changed the title fix: use case-converter for json component serialization fix: use case converter for json component serialization Feb 14, 2022
@muchnameless muchnameless mentioned this pull request Feb 14, 2022
Closed
vladfrangu
vladfrangu approved these changes Feb 14, 2022
View reviewed changes
@suneettipirneni suneettipirneni force-pushed the fix/json-component-serialization branch from 8482d11 to aeefd1d Compare February 14, 2022 16:25
kyranet
kyranet previously requested changes Feb 14, 2022
View reviewed changes
@iCrawl iCrawl added this to the discord.js v14 milestone Feb 15, 2022
@monbrey monbrey mentioned this pull request Feb 15, 2022
Closed
@suneettipirneni suneettipirneni mentioned this pull request Feb 15, 2022
Merged
6 tasks
@kyranet kyranet linked an issue Feb 15, 2022 that may be closed by this pull request
Footer not showing #7469
Closed
SpaceEEC
SpaceEEC approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine as-is, but maybe we want to use a built-in for that (see comment) instead.

@iCrawl iCrawl merged commit 2d45544 into discordjs:main Feb 16, 2022
@suneettipirneni suneettipirneni deleted the fix/json-component-serialization branch July 6, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

Footer not showing
6 participants
@suneettipirneni @vladfrangu @iCrawl @kyranet @SpaceEEC @ImRodry