Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(MessageCreate): remove message event #6324

Merged
merged 3 commits into from
Jan 8, 2022
Merged

refactor(MessageCreate): remove message event #6324

merged 3 commits into from
Jan 8, 2022

Conversation

MattIPv4
Copy link
Contributor

@MattIPv4 MattIPv4 commented Aug 6, 2021

Please describe the changes this PR makes and why it should be merged:

First(?) semver major PR ready for v14 -- removes the deprecated client message event.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@iCrawl
Copy link
Member

iCrawl commented Aug 6, 2021

Slash commands only 😨

@iCrawl iCrawl added this to the Version 14 milestone Aug 6, 2021
@MattIPv4 MattIPv4 mentioned this pull request Aug 6, 2021
Merged
@MattIPv4 MattIPv4 force-pushed the remove-message-event branch from 6c4d491 to aeaa5fb Compare August 11, 2021 00:30
vladfrangu
vladfrangu approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@iCrawl iCrawl added the gateway label Aug 12, 2021
@iCrawl iCrawl requested review from kyranet and SpaceEEC August 17, 2021 20:46
@MattIPv4 MattIPv4 force-pushed the remove-message-event branch from aeaa5fb to 1cb04fa Compare October 3, 2021 12:36
@MattIPv4 MattIPv4 force-pushed the remove-message-event branch 2 times, most recently from d87bfc6 to 2bb744d Compare October 13, 2021 13:05
@MattIPv4 MattIPv4 force-pushed the remove-message-event branch from 2bb744d to dcf0d03 Compare December 16, 2021 12:34
@MattIPv4 MattIPv4 force-pushed the remove-message-event branch from dcf0d03 to 0e8b53e Compare January 8, 2022 13:29
@iCrawl iCrawl merged commit 171e917 into discordjs:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
gateway packages:discord.js semver:major
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.
5 participants
@MattIPv4 @iCrawl @vladfrangu @kyranet @SpaceEEC