Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(User): support user banners #5930

Closed
wants to merge 8 commits into from
Closed

feat(User): support user banners #5930

wants to merge 8 commits into from

Conversation

Koyamie
Copy link
Contributor

@Koyamie Koyamie commented Jun 26, 2021

Please describe the changes this PR makes and why it should be merged:
With the recent releases of user banners for everyone, Discord confirmed they will add the banner image hash to the user object.
See discord/discord-api-docs#3095 (comment)

This PR supports the banner field.

Do not merge until the field is accessible via the API.

Status and versioning classification:

  • This PR changes the library's interface (methods or parameters added)

@Koyamie Koyamie marked this pull request as draft June 26, 2021 14:55
@DTrombett
Copy link
Contributor

Typings for User class need to be updated.

@Koyamie
Copy link
Contributor Author

Koyamie commented Jun 26, 2021

I am not familiar with typings but this should do the job? Tell me if I missed something

@DTrombett
Copy link
Contributor

DTrombett commented Jun 26, 2021

They should be ok 👍

@GoldenAngel2
Copy link
Contributor

GoldenAngel2 commented Jun 26, 2021

User.equals needs to be updated

👍

typings/index.d.ts Outdated Show resolved Hide resolved
@u9g
Copy link
Contributor

u9g commented Jun 26, 2021

In what situation would the users be equal but the banners be unequal that makes the equal function fail?

@DTrombett
Copy link
Contributor

That's the same as other properties. I guess it's there to check two users object that may refer to the same user.

@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@advaith1
Copy link
Contributor

banner and banner_color are documented in discord/discord-api-docs#3448 and are currently accessible via the canary API (in ClientOptions: http: {headers: {'x-debug-options': 'canary'}} or http: {api: 'https://canary.discord.com/api'})

@Koyamie
Copy link
Contributor Author

Koyamie commented Jul 15, 2021

I'll need someone else to take care of that PR because I won't be available for the next 2 weeks and Discord seems to be slowly releasing the banner on the API.

@iCrawl
Copy link
Member

iCrawl commented Jul 15, 2021

@advaith1 will be taking over in a new PR.

@iCrawl iCrawl closed this Jul 15, 2021
@Koyamie Koyamie deleted the patch-1 branch August 5, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants