-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(User): support user banners #5930
Conversation
don't mind it for now, just trying
Typings for |
I am not familiar with typings but this should do the job? Tell me if I missed something |
They should be ok 👍 |
👍 |
In what situation would the users be equal but the banners be unequal that makes the equal function fail? |
That's the same as other properties. I guess it's there to check two users object that may refer to the same user. |
|
I'll need someone else to take care of that PR because I won't be available for the next 2 weeks and Discord seems to be slowly releasing the banner on the API. |
@advaith1 will be taking over in a new PR. |
Please describe the changes this PR makes and why it should be merged:
With the recent releases of user banners for everyone, Discord confirmed they will add the banner image hash to the user object.
See discord/discord-api-docs#3095 (comment)
This PR supports the banner field.
Do not merge until the field is accessible via the API.
Status and versioning classification: