feat(GuildMemberManager): add 'search' method

[izexi]

Ref: discord/discord-api-docs#1577
This PR will be marked as draft until the referenced PR above has been merged.

Status

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

• This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
• This PR only includes non-code changes, like changes to documentation, README, etc.

[advaith1]

This is basically just a duplicate of GuildMemberManager#fetch but over REST; is it necessary?

[vladfrangu]

Yes, for API coverage 😄

[advaith1]

I don't think discord.js supports the List Guild Members endpoint though?, because that can also be done through #fetch which uses the gateway. IMO it's pointless to have two methods that do the same thing but in different ways, as that's likely to confuse users and leads to unnecessary bloat.

[vladfrangu]

Fair, we don't support all endpoints yet, however it doesn't mean we shouldn't support both... This would he especially beneficial for anyone that uses d.js in a more stateless manner (if they manage that) as well!

As for user confusion... Documentation can clarify that .fetch can* include presences too (via intent and option, as well as fetching specific user IDs, while the rest endpoint lets you just search by start of nickname/username)

That's just my opinion tho 👍

[izexi]

The referenced PR has finally been merged