Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix duplicate props in merged interfaces #10160

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Mar 2, 2024

Please describe the changes this PR makes and why it should be merged:
Currently classes like BaseGuildTextChannel show duplicate members (e.g. client) in the documentation, because they exist both in the interface and the class that gets declaration merged in the index.d.ts file. This removes the common members from the interface to only have them declared once.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner March 2, 2024 17:53
Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 6:54am
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 6:54am

@Jiralite Jiralite changed the title types(discord.js): fix duplicate props in merged interfaces types: fix duplicate props in merged interfaces Mar 2, 2024
@iCrawl iCrawl merged commit a1010c6 into discordjs:main Mar 4, 2024
6 checks passed
@Qjuh Qjuh deleted the types/interface-merge-fix branch March 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants