Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolveColor): Address case for numbers #10115

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(resolveColor): Address case for numbers #10115

merged 2 commits into from
Feb 5, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Feb 2, 2024

Please describe the changes this PR makes and why it should be merged:
Resolves #10114: the logic for handling a number was removed in #10108 due to no longer overwriting the parameter.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite requested a review from a team as a code owner February 2, 2024 14:41
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 10:10pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 10:10pm

@Jiralite Jiralite added this to the discord.js 14.15 milestone Feb 2, 2024
SpaceEEC
SpaceEEC approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests? Anyone?

@kodiakhq kodiakhq bot merged commit 3755e66 into main Feb 5, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the fix/resolve-colour-number branch February 5, 2024 22:11
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@lockyz lockyz mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@WhyAydan WhyAydan mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@AzhamProdLive AzhamProdLive mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@almeidx almeidx almeidx approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch utility
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
Development

Successfully merging this pull request may close these issues.

Unable to convert "15548997" to a number.
4 participants
@Jiralite @kyranet @SpaceEEC @almeidx