fix(InteractionResponses): do not use in if a string is passed

discordjs · Dec 24, 2024 · ff42d7a · ff42d7a
1 parent 0fdbabe
commit ff42d7a
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/packages/discord.js/src/structures/interfaces/InteractionResponses.js b/packages/discord.js/src/structures/interfaces/InteractionResponses.js
@@ -162,24 +162,26 @@ class InteractionResponses {
   async reply(options) {
     if (this.deferred || this.replied) throw new DiscordjsError(ErrorCodes.InteractionAlreadyReplied);
 
-    if ('ephemeral' in options) {
-      if (!deprecationEmittedForEphemeralOption) {
-        process.emitWarning(
-          `Supplying "ephemeral" for interaction response options is deprecated. Utilize flags instead.`,
-        );
-
-        deprecationEmittedForEphemeralOption = true;
+    if (typeof options !== 'string') {
+      if ('fetchReply' in options) {
+        if (!deprecationEmittedForEphemeralOption) {
+          process.emitWarning(
+            `Supplying "ephemeral" for interaction response options is deprecated. Utilize flags instead.`,
+          );
+
+          deprecationEmittedForEphemeralOption = true;
+        }
       }
-    }
 
-    if ('fetchReply' in options) {
-      if (!deprecationEmittedForFetchReplyOption) {
-        process.emitWarning(
-          // eslint-disable-next-line max-len
-          `Supplying "fetchReply" for interaction response options is deprecated. Utilize "withResponse" instead or fetch the response after using the method.`,
-        );
+      if ('fetchReply' in options) {
+        if (!deprecationEmittedForFetchReplyOption) {
+          process.emitWarning(
+            // eslint-disable-next-line max-len
+            `Supplying "fetchReply" for interaction response options is deprecated. Utilize "withResponse" instead or fetch the response after using the method.`,
+          );
 
-        deprecationEmittedForFetchReplyOption = true;
+          deprecationEmittedForFetchReplyOption = true;
+        }
       }
     }
 
@@ -331,7 +333,7 @@ class InteractionResponses {
   async update(options) {
     if (this.deferred || this.replied) throw new DiscordjsError(ErrorCodes.InteractionAlreadyReplied);
 
-    if ('fetchReply' in options) {
+    if (typeof options !== 'string' && 'fetchReply' in options) {
       if (!deprecationEmittedForFetchReplyOption) {
         process.emitWarning(
           // eslint-disable-next-line max-len