fix(GatewayGuildDeleteDispatchData): make unavailable optional #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vladfrangu
requested changes
Dec 28, 2023
| @@ -847,7 +847,8 @@ export type GatewayGuildDeleteDispatch = DataPayload<GatewayDispatchEvents.Guild | |||
| /** | |||
| * https://discord.com/developers/docs/topics/gateway-events#guild-delete | |||
| */ | |||
| export type GatewayGuildDeleteDispatchData = APIUnavailableGuild; | |||
| export type GatewayGuildDeleteDispatchData = Omit<APIUnavailableGuild, 'unavailable'> & | |||
There was a problem hiding this comment.
Lets make this its own interface
almeidx
approved these changes
Jul 2, 2024
|
Superseded by #1092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unavailablefield inGatewayGuildDeleteDispatchDatacan be undefined, but in the API types, it's marked as always present. Even though the documentation specifies that it's an unavailable guild, and the example object has the field present, it says that the field can be not set:I also confirmed this with some of my own testing. I added and then kicked a bot from a guild, and got a guild delete event without the
unavailablefield. One thing I'm not sure about though is if the optional should be onAPIUnavailableGuildinstead of the dispatch, as the docs are vague on the details.