Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner close button #93

Merged
merged 7 commits into from
Mar 9, 2024
Merged

Conversation

femshima
Copy link
Contributor

@femshima femshima commented Mar 7, 2024

質問者がスレッドをクローズするボタンを作ります.

「問題が解決した場合、スレッドを閉じるようお願いいたします。」の文意が伝わりにくいという懸念があり,いっそボタンにしてしまおうという提案です.

@femshima femshima marked this pull request as ready for review March 7, 2024 12:14
@tignear
Copy link
Contributor

tignear commented Mar 7, 2024

私がよくわかってないだけならいいんだけどこれどこでスレッドのオーナーのみがボタンを操作してcloseが行えることを保証するようになってるの?(私には誰でも閉じれそうに見えています)

@femshima
Copy link
Contributor Author

femshima commented Mar 7, 2024

完全に忘れていました(修正しました)

src/index.js Outdated Show resolved Hide resolved
Copy link
Member

@InkoHX InkoHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです👍

@InkoHX
Copy link
Member

InkoHX commented Mar 9, 2024

@femshima マージしちゃいます。ありがとうございました!

@InkoHX InkoHX merged commit ce7feb5 into discordjs-japan:main Mar 9, 2024
2 checks passed
@femshima femshima deleted the owner-close branch March 9, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants