ModifyAsync Attachments Bug Fix #2236

[DeclanFrampton]

PR in relation to #2236

Edits Permitted

Simple fix, could be improved if necessary. ModifyAsync can now has access to an Attachment object if an empty array is passed the image(s) will be removed from the target interaction being modified.

[DeclanFrampton]

Test interactions to make life easier for reviewer.

[SlashCommand("create_embed", "creates embed with image")]
public async Task CreateEmbed()
{
    var fileBuffer = await File.ReadAllBytesAsync("file_path_here");
    var file = new FileAttachment(new MemoryStream(fileBuffer), "test.png");

    await RespondWithFileAsync(file, embed: new EmbedBuilder()
    {
        Title = "Test",
        Description = "Test Desc",
        Color = Discord.Color.DarkBlue,
        Footer = new EmbedFooterBuilder()
        {
            Text = "Test Foot"
        },
        ImageUrl = "attachment://test.png",

    }.Build(),
    components: new ComponentBuilder()
        .WithButton("Modify - Keep Image", "keep-image")
        .WithButton("Modify - Remove Image", "remove-image", ButtonStyle.Secondary)
        .Build(),
    ephemeral: true).ConfigureAwait(false);
}

[ComponentInteraction("remove-image")]
public async Task UpdateEmbedImage()
{
    await Context.Interaction.DeferAsync(true)
        .ConfigureAwait(false);

    var origInteraction = await Context.Interaction.GetOriginalResponseAsync()
        .ConfigureAwait(false);

    await origInteraction.ModifyAsync(x =>
    {
        x.Attachments = null;
        x.Embed = new EmbedBuilder()
        {
            Title = "Remove Image Modify Test",
            Description = "Modify Test",
            Color = Discord.Color.DarkBlue,
        }.Build();
    }).ConfigureAwait(false);
}

[ComponentInteraction("keep-image")]
public async Task KeepEmbedImage()
{
    await Context.Interaction.DeferAsync(true)
        .ConfigureAwait(false);

    var origInteraction = await Context.Interaction.GetOriginalResponseAsync().ConfigureAwait(false);

    await origInteraction.ModifyAsync(x =>
    {
        x.Embed = new EmbedBuilder()
        {
            Title = "Keep Images Modify Test",
            Description = "Modify Test",
        }.Build();
    }).ConfigureAwait(false);
}

[Almighty-Shogun]

How about settings Attachments to null instead of passing an empty array? 🤔

[DeclanFrampton]

How about settings Attachments to null instead of passing an empty array? 🤔

Just reminded me that I actually tried that but instead of investigating the issue with that I got side tracked. Will push another commit later for this, the issue exists in the else statement of checking if attachments are specified, if they are not we enter the else scope and pass the attachments and convert to array without checking if the value is null.