refactor(extension): set background script as non persistent and remo…

…ve html template background script do not use any persistent background feature, this was a legacy thing, this will definitely be a big take on performance improvement https://developer.chrome.com/extensions/background_migration
dis-moi · Feb 3, 2020 · 59d03aa · 59d03aa
1 parent c2e2f0d
commit 59d03aa
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 20 deletions.
diff --git a/manifest/base.js b/manifest/base.js
@@ -16,7 +16,8 @@ module.exports = Object.freeze({
   manifest_version: 2,
   icons,
   background: {
-    page: 'background.html'
+    scripts: ['/js/browser-polyfill.js', 'js/background.bundle.js'],
+    persistent: false
   },
   content_scripts: [
     {
@@ -54,7 +55,7 @@ module.exports = Object.freeze({
     default_title: 'Bulles'
   },
   permissions: ['activeTab', 'storage'],
-  web_accessible_resources: ['img/*', 'fonts/*'],
+  web_accessible_resources: ['img/*', 'fonts/*']
   // externally_connectable: {
   //   matches: ['https://*.lmem.net/*']
   // }

diff --git a/views/background.pug b/views/background.pug
diff --git a/views/includes/devtools.pug b/views/includes/devtools.pug
diff --git a/webpack/config.plugins.js b/webpack/config.plugins.js
@@ -73,11 +73,6 @@ module.exports = (env = {}, argv = {}, buildPath) => {
       'process.env': processENVVarsToInject(env)
     }),
     new ModuleNotFoundPlugin(path.resolve(__dirname, '..')),
-    new HtmlWebpackPlugin({
-      template: './views/background.pug',
-      filename: 'background.html',
-      inject: false
-    }),
     new HtmlWebpackPlugin({
       template: './views/options.pug',
       filename: 'options.html',